Added an html validation check by looking at Nokogiri errors #125
Conversation
|
All right, I am less grumpy about this now. Plus I like that it's a separate, non-default option. Can you update the README with the new option? Everything else looks grand. |
| svg audio embed source track video) | ||
|
|
||
| def run | ||
| return unless @options[:validate_html] |
There was a problem hiding this comment.
Ah, because get_checks would've deleted it above?
There was a problem hiding this comment.
Yeah. If I want to run this check directly, I shouldn't need to know about the validate_html option, should I? If I'm calling it directly, the understanding would be that validate_html would be true. This is useful if I want to validate the HTML in some documents, but not all.
There was a problem hiding this comment.
I copied this from the favicon code:
Do you still want me to remove it here?
There was a problem hiding this comment.
i think both should be removed
akoeplinger
force-pushed
the
html-validation
branch
from
3b832ec
to
f21ff1f
Compare
|
Added docs to readme, let me know if there's something else I can do. |
akoeplinger
force-pushed
the
html-validation
branch
from
f21ff1f
to
e413f18
Compare
akoeplinger
force-pushed
the
html-validation
branch
from
e413f18
to
7d7068e
Compare
|
@akoeplinger I would agree that the favicon |
|
@gjtorikian sorry if that sounds pedantic, but I'd like to keep this PR focused on the new feature and not change unrelated code. |
|
😌 👍 🎉 Glad this is making its way in! |
Added an html validation check by looking at Nokogiri errors
I know you said in #30 you're not interested in validating HTML, but Nokogiri already looks at the markup and provides errors when parsing, so providing basic validation is quite easy.
This simple checker helped me catch a few mistakes in my site, so I thought I'd try and see if you find it useful now 😄